Add Zephyr support #1615
Merged
Add Zephyr support #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboasson
reviewed
Mar 20, 2023
There was a problem hiding this comment.
Thanks @PatrickM-ZS, this is a nice addition to the set of platforms that Cyclone runs on. LGTM, except for the build failures on Windows (sign conversion warning, but all warnings get treated as errors). That shouldn't take much effort to fix.
|
It seems GCC is unhappy about struct signedness now, I'll take another look... |
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Extend Zephyr RTOS support Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Add workaround for plist struct alignment for Zephyr Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Move plist alignment workaround for Zephyr to ddsrt_alignof and deal with arm32 short enums Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Fix joining mcgroups multiple times and add igmp support for Zephyr Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Add sockwaitset support + some other fixes for Zephyr Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Revert "Move plist alignment workaround for Zephyr to ddsrt_alignof and deal with arm32 short enums" This reverts commit 73b1bf0. Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech> Revert "Add workaround for plist struct alignment for Zephyr" This reverts commit 4927618. Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
The (gcc) option -fshort-enums causes the enumerated types used in the discovery information to become char-sized things instead of int-sized things. This breaks the plist serializer in really bad ways. Additionally, there are some platforms where _Alignof returns a larger alignment than what the compiler uses as alignment of a struct member (without having used #pragma pack or similar). This also breaks the plist serializer in really bad ways. This commit attempts to address these issues by serialising an enum using a enum type that also fits in 1 byte, and by computing the alignment of a struct member via offsetof in the plist handling. Signed-off-by: Erik Boasson <eb@ilities.com>
…ilters in nxp s32 ethernet driver Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
Signed-off-by: Patrick Masselink <patrick.masselink@zettascale.tech>
PatrickM-ZS
force-pushed
the
zephyr-support
branch
from
f706b9f
to
d298379
Compare
|
This test fail on the macOS 11 target seems to be a common issue, caused by slow cloud infra? |
Yes, those macOS targets often have such timing issues. Timing out on a "slow path" is quite fitting, I must say 😂 |
eboasson
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for running CycloneDDS on Zephyr RTOS.
It was validated on Zephyr targets
qemu_x86,qemu_cortex_a53(emulators) ands32z270dc2_rtu0_r52(physical board), using the CycloneDDS examples and ddsperf tool. Supporting code and usage examples are still in my personal repository here but I intend to clean that up and merge it (into the ports directory) in a future PR.