Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: adds info about stale issues/PRs #1421

Merged
merged 2 commits into from
Jun 7, 2022
Merged

Doc: adds info about stale issues/PRs #1421

merged 2 commits into from
Jun 7, 2022

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

Adds a section to CONTRIBUTING.md about labeling issues and PRs stale and then auto-closing them.

Why it does that

Full transparency and disclosure

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

alexandrudanciu
alexandrudanciu approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@alexandrudanciu alexandrudanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged in my opinion, nevertheless, I also added some improvement suggestions.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@paullatzelsperger @alexandrudanciu
Apply suggestions from code review
9454908 
Co-authored-by: alexandrudanciu <80531692+alexandrudanciu@users.noreply.github.com>
@paullatzelsperger paullatzelsperger merged commit 5be3459 into eclipse-edc:main Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mspiekermann mspiekermann mspiekermann approved these changes

@alexandrudanciu alexandrudanciu alexandrudanciu approved these changes

@MoritzKeppler MoritzKeppler Awaiting requested review from MoritzKeppler

@juliapampus juliapampus Awaiting requested review from juliapampus juliapampus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paullatzelsperger @mspiekermann @alexandrudanciu