provided unit tests for "weak" eTag comparison recently fixed

eclipse-ditto · May 14, 2024 · 4889b0a · 4889b0a
1 parent 23d7884
commit 4889b0a
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/...a/org/eclipse/ditto/internal/utils/headers/conditional/IfMatchPreconditionHeaderTest.java b/...a/org/eclipse/ditto/internal/utils/headers/conditional/IfMatchPreconditionHeaderTest.java
@@ -55,6 +55,13 @@ public void meetsCondition() {
         assertThat(ifMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("\"4711\""))).isTrue();
     }
 
+    @Test
+    public void meetsConditionForWeak() {
+        final IfMatchPreconditionHeader ifMatchPreconditionHeader =
+                createIfMatchPreconditionHeader(fromCommaSeparatedString("W/\"4711\""));
+        assertThat(ifMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isTrue();
+    }
+
     @Test
     public void doesNotMeetConditionForNull() {
         final IfMatchPreconditionHeader ifMatchPreconditionHeader =

diff --git a/...g/eclipse/ditto/internal/utils/headers/conditional/IfNoneMatchPreconditionHeaderTest.java b/...g/eclipse/ditto/internal/utils/headers/conditional/IfNoneMatchPreconditionHeaderTest.java
@@ -57,6 +57,14 @@ public void doesNotMeetConditionForEqualOpaqueTag() {
         assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isFalse();
     }
 
+    @Test
+    public void doesNotMeetConditionForEqualOpaqueTagForWeak() {
+        final IfNoneMatchPreconditionHeader ifNoneMatchPreconditionHeader =
+                createIfNoneMatchPreconditionHeader(EntityTagMatchers.fromCommaSeparatedString("W/\"4711\""));
+        assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("\"4711\""))).isTrue();
+        assertThat(ifNoneMatchPreconditionHeader.meetsConditionFor(EntityTag.fromString("W/\"4711\""))).isFalse();
+    }
+
     @Test
     public void meetsConditionForNull() {
         final IfNoneMatchPreconditionHeader ifNoneMatchPreconditionHeader =