Skip to content

Commit

Permalink
Do not log a stream completion exception as failed message consumption
Browse files Browse the repository at this point in the history
* This will appear as failure in the connection metrics for consumed messages
  which is wrong because it's not related to a consumed message

Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
  • Loading branch information
Yannic92 committed Aug 16, 2021
1 parent 251c34f commit 8d3f8b6
Showing 1 changed file with 0 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,6 @@ private void handleStreamCompletion(@Nullable final Done done, @Nullable final T
log.debug("Consumer failed with error! <{}: {}>", throwable.getClass().getSimpleName(),
throwable.getMessage());
status = connectivityStatusResolver.resolve(throwable);
final ConnectivityInternalErrorException exception = ConnectivityInternalErrorException.newBuilder()
.cause(throwable)
.message(throwable.getMessage())
.description("Unexpected consumer failure.")
.build();
inboundMonitor.exception(exception);
escalate(throwable, "Unexpected consumer failure.");
}
final ResourceStatus statusUpdate = ConnectivityModelFactory.newStatusUpdate(
Expand Down

0 comments on commit 8d3f8b6

Please sign in to comment.