Add methods to TopicPath to make its evaluation easier #1043
Assignees
Milestone
Comments
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…PathBuilder` to package level. Added a unit test. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…ments of `ImmutableTopicPath`. * `ImmutableTopicPathBuilder` is now a private nested class of `ImmutableTopicPath` to be able to refer to to its instance field in constructor. * An instance of `ImmutableTopicPath` can now only be obtained via builder. Thus removed static factory methods. * Moved parsing of TopicPath string representation from `ProtocolFactory` to `ImmutableTopicPath` to make use of the nested builder. * Reworked parsing of `TopicPath` from string to provide meaningful context in case of errors. * Adjusted some Javadoc comments to reflect the code. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…icPath`. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
….` methods of `TopicPath`. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…h#getPath()` and added a unit test that covers an empty namespace part. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…to Protocol messages are always required to have a topic. Thus an empty topic path implementation did not make sense. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…ges to add `@Nullable` annotations. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
`HeaderTranslator#fromExternalHeaders(Map)` might return an unmodifiable Map. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
* Removed unused methods. * Re-ordered methods according to the Stepdown Rule. * Moved method `getEventTopicPathBuilderFor` to `AbstractThingAdapter` as it is only used by sub-classes thereof. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…ckages to add `@Nullable` annotations. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
…er branch. Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b
pushed a commit
to bosch-io/ditto
that referenced
this issue
May 4, 2021
Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are situations where a
TopicPathof a Ditto Protocol Message should be evaluated.For example, if one wants to know whether the group is "Things" or the its action is "create", the appropriate getter methods have to be called.
The result of those getters is sometimes an
Optionalwhich puts another indirection to the evaluation.To make evaluation of a
TopicPatheasier, methods should be added which returnbooleanlike for exampleThe text was updated successfully, but these errors were encountered: