Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target-only Kafka connection remains "open" even if Kafka broker is not available. #1273

Closed
jufickel-b opened this issue Jan 14, 2022 · 0 comments · Fixed by #1278
Closed

Target-only Kafka connection remains "open" even if Kafka broker is not available. #1273

jufickel-b opened this issue Jan 14, 2022 · 0 comments · Fixed by #1278
Assignees
@jufickel-b
Labels
bug
Milestone
2.3.0

Comments

@jufickel-b
Copy link

A Kafka connection without sources does no regular poll and thus cannot detect whether the broker is available.

This means a Kafka connection with only targets remains open even if Kafka broker is not available.
Such a connection should be marked as "misconfigured".
As it is not possible to detect this state pre-emptively it should be detected at least with the first sent message that times out.
@jufickel-b jufickel-b self-assigned this Jan 14, 2022
jufickel-b pushed a commit to bosch-io/ditto that referenced this issue Jan 18, 2022
Issue eclipse-ditto#1273: Deal with unavailable Kafka broker in Kafka…
fc7a047 
…PublisherActor.

Until now a Ditto Kafka connection with targets only did not cope properly with the Kafka broker becoming unavailable.
In such cases, publishing timed out and produced appropriate entries in connection log.
Connection live status however, remained always 'open'.
With this commit, a TimeoutException while publishing is handled in a way that a ConnectionFailure is propagated to parent BaseClientActor.
This sets connection live status to 'misconfigured' and triggers reconnect with back-off semantic.
Thus, a potentially unavailable Kafka broker gets appropriately reflected by connection status.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
jufickel-b pushed a commit to bosch-io/ditto that referenced this issue Jan 18, 2022
Issue eclipse-ditto#1273: Moved logic for escalating connection failu…
b8f87db 
…re to avoid unwanted side effects.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch.io>
@thjaeckle thjaeckle mentioned this issue Jan 18, 2022
Merged
@thjaeckle thjaeckle added this to the 2.3.0 milestone Jan 20, 2022
@stmaute stmaute mentioned this issue Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jufickel-b jufickel-b

Labels
bug
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

Deal with unavailable Kafka broker in publisher bosch-io/ditto
2 participants
@thjaeckle @jufickel-b