Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm chart] Allow otelExporterOtlpEndpoint value to contain Release/Values references #1731

Closed
calohmn opened this issue Sep 5, 2023 · 0 comments · Fixed by #1737
Closed
Assignees
Milestone

Comments

@calohmn
Copy link
Contributor

calohmn commented Sep 5, 2023

When deploying the ditto Helm chart as part of the IoT Packages cloud2edge chart, it would be useful to provide combined tracing support for Ditto and Hono. The straightforward thing to do for this, would be enabling tracing support in the Hono chart, and referencing the corresponding OTLP endpoint in the Ditto tracing configuration.
This would mean setting ditto.global.tracing.otelExporterOtlpEndpoint to http://c2e-jaeger-collector:4317 for example. But this only works if the used release name when deploying the cloud2edge chart is indeed c2e.

To support arbitrary release names, http://{{ .Release.Name }}-jaeger-collector:4317 would have to be used as otelExporterOtlpEndpoint value.

In order for this to work, the ditto Helm chart would just need to use the tpl function in the place where otelExporterOtlpEndpoint gets used. This is a feature request for doing so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants