Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging by adding the W3C traceparent header as MDC field to logs #1739

Closed
thjaeckle opened this issue Sep 8, 2023 · 0 comments · Fixed by #1740
Closed

Improve logging by adding the W3C traceparent header as MDC field to logs #1739

thjaeckle opened this issue Sep 8, 2023 · 0 comments · Fixed by #1740
Milestone
3.4.0

Comments

@thjaeckle
Copy link
Member

Currently, only the "correlation-id" is logged to the MDC for each log-statement in Ditto.

When having tracing activated, it would be very useful to also provide the traceparent, as defined by the W3C TraceContext, as an MDC field.
@thjaeckle thjaeckle added this to the 3.4.0 milestone Sep 8, 2023
thjaeckle added a commit that referenced this issue Sep 8, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
b41932c 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields
@thjaeckle thjaeckle mentioned this issue Sep 8, 2023
Merged
thjaeckle added a commit that referenced this issue Sep 8, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
3770ebc 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields
thjaeckle added a commit that referenced this issue Sep 8, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
a3650a9 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 11, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
d547ec9 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 11, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
3cd2513 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 11, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
ad15325 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 11, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
7635ddb 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 12, 2023
@thjaeckle
#1739 log 2 separate MDC fields: "traceparent-trace-id" and "tracepar…
592150f 
…ent-span-id"

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 18, 2023
@thjaeckle
#1739 provide the traceparent header as MDC value in logs
88d7fa8 
* generify the fields to provide to the MDC in CommonMdcEntryKey enum
* rename "x-correlation-id" in logs to just "correlation-id"
* exchange some places where only correlationId was extracted from a map of headers with parsing all the headers for MDC worthy fields

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 18, 2023
@thjaeckle
#1739 log 2 separate MDC fields: "traceparent-trace-id" and "tracepar…
707c773 
…ent-span-id"

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 19, 2023
@thjaeckle
#1739 removed IntLevelJsonProvider from default logback files in Helm…
cb51e3a 
… chart

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 19, 2023
@thjaeckle
#1739 undid chart changes
62df02f 
Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle added a commit that referenced this issue Sep 19, 2023
@thjaeckle
Merge pull request #1740 from eclipse-ditto/feature/log-tracing-context
e5f32fd 
#1739 provide the traceparent header as MDC value in logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

#1739 provide the traceparent header as MDC value in logs eclipse-ditto/ditto
1 participant
@thjaeckle