Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a built-in acknowledgement label for search index update #914

Closed
yufei-cai opened this issue Dec 11, 2020 · 0 comments · Fixed by #928
Closed

Add a built-in acknowledgement label for search index update #914

yufei-cai opened this issue Dec 11, 2020 · 0 comments · Fixed by #928
Milestone
2.0.0-M1

Comments

@yufei-cai
Copy link
Contributor

The search index is only eventually consistent. Applications that rely on search to for twin interactions will need to know when a change is reflected in the search index. It is straightforward to support that by adding a built-in acknowledgement label "search-persisted" for twin modify commands and issue acknowledgements after search index update completes.
@thjaeckle thjaeckle added this to the 2.0.0 milestone Dec 14, 2020
yufei-cai added a commit to bosch-io/ditto that referenced this issue Dec 22, 2020
@yufei-cai
[eclipse-ditto#914] Add Ditto acknowledgement label "search-persisted".
667c9c6 
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
yufei-cai added a commit to bosch-io/ditto that referenced this issue Dec 22, 2020
@yufei-cai
[eclipse-ditto#914] send search-persisted acknowledgements.
35856a6 
Duplicate-key errors are considered successes because they may
happen during upsert.

Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
yufei-cai added a commit to bosch-io/ditto that referenced this issue Dec 22, 2020
@yufei-cai
[eclipse-ditto#914] document "search-persisted".
3969c60 
Signed-off-by: Yufei Cai <yufei.cai@bosch.io>
yufei-cai pushed a commit to bosch-io/ditto that referenced this issue Dec 22, 2020
@thjaeckle
[eclipse-ditto#914] review:
4992d82 
* some minor simplifications
* solved some deprecation warnings using deprecated Akka APIs
* adjusted since version to 2.0.0
* updated mutability-detector.version

Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch.io>
@yufei-cai yufei-cai mentioned this issue Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0-M1
Development

Successfully merging a pull request may close this issue.

Add built-in acknowledgement label "search-persisted" bosch-io/ditto
2 participants
@thjaeckle @yufei-cai