-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for connecting to an external system via an SSH tunnel #1020
Merged
thjaeckle
merged 44 commits into
eclipse-ditto:master
from
bosch-io:feature/support-ssh-over-connection
Apr 6, 2021
Merged
Add support for connecting to an external system via an SSH tunnel #1020
thjaeckle
merged 44 commits into
eclipse-ditto:master
from
bosch-io:feature/support-ssh-over-connection
Apr 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
…nnel. Ssh tunnel management is done in new SshTunnelActor. The tunnel is controlled (open/close) with the existing state machine in BaseClientActor. Add connecting via tunnel for existing protocols (except Kafka, which requires multiple connections to bottstrap server and zookeeper). Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
…stablish ssh tunnel when testing a connection Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…add username to ssh public key credentials Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…ion for parsing errors to ExceptionMapper Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…ession (no default fallbacks) Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…lobally Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…s null in connectivity error responses Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
… it from basic section Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…rformance impact of using ssh tunneling Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…d without required configuration, restart tunnel actor in case of an unexpected failure Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…face to improve testability Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
…sh tunneling Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
thjaeckle
reviewed
Apr 6, 2021
model/connectivity/src/main/java/org/eclipse/ditto/model/connectivity/ConnectionBuilder.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
...onnectivity/src/main/java/org/eclipse/ditto/model/connectivity/ConnectivityModelFactory.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
model/connectivity/src/main/java/org/eclipse/ditto/model/connectivity/CredentialsVisitor.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
model/connectivity/src/main/java/org/eclipse/ditto/model/connectivity/CredentialsVisitor.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
...connectivity/src/main/java/org/eclipse/ditto/model/connectivity/SshPublicKeyCredentials.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
model/connectivity/src/main/java/org/eclipse/ditto/model/connectivity/SshTunnelBuilder.java
Show resolved
Hide resolved
thjaeckle
reviewed
Apr 6, 2021
...connectivity/src/main/java/org/eclipse/ditto/model/connectivity/UserPasswordCredentials.java
Show resolved
Hide resolved
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
Signed-off-by: Vadim Guenther <vadim.guenther@bosch.io>
@thjaeckle i added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #985. It extends the managed connections with support for establishing a local port forwarding to an external system, e.g. a broker, via an SSH connection. Ditto takes care of creating the tunnel and using it transparently to connect to the actual endpoint when the functionality is enabled in the connection's configuration.