Collect Apache Kafka consumer metrics #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements KafkaConsumerMetricsRegistry as singleton for collecting the Apache Kafka consumer metrics. Some minor code styling refactorings. Adjust ClientActorPropsFactory to be a singleton, since it doesn't have any state. Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Adds Kamon gauges for kafka consumer metrics. The kamon gauges report the metric values as double. Thus also added double gauge API to Gauge. Remembers new consumers for metric reporting init, since the consumerControl is not ready from the get-go and produces NullPointerException if the metrics are accessed directly after instantiation. Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
* Passing the KafkaConsumerMetricsRegistry to the KafkaConsumerStreamFactory since it is used for all kinds of streams. * Using a unique identifier per stream to make sure that each stream has its own metrics available. Before we only could distinguish between qos 0 and qos 1 per connection. * Remove concept of Remember registration and just register immediately * Handle NullpointerException which seems to be a bug in kafka streams Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
…her successfully or execptionally * This makes the registration more stable/consistent because it's less likely that a developer forgets to de-register or makes de-register wrong (see previous commit) Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
In effort to fix immutability test failures: "The 'this' reference is passed outwith the constructor." Signed-off-by: David Schwilk <david.schwilk@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
…or instead * This avoids manual thread handling Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
DerSchwilk
commented
Nov 12, 2021
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect Apache Kafka consumer metrics via Alpakka and expose them to Prometheus via Kamon metrics.