Fix that redeliveries for acknowledgeable connectivity messages were issued too often #1657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssued to often * removed generic `acknowledgeableMessage.reject(true)` on encountered exceptions * the logic where the status code of the DittoRuntimeException is handled did not even take a part in the redelivery Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
thjaeckle
changed the title
|
@kalinkostashki @alstanchev a review would be great. This is a small bugfix which however causes that e.g. 403 (forbidden) or 404 (not found) errors are retried over and over again - without the chance of ever succeeding. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
acknowledgeableMessage.reject(true)on encountered exceptions