Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helm): Allow connectivity inter cluster communication #1676

Merged
merged 2 commits into from Jul 3, 2023
Merged

fix(helm): Allow connectivity inter cluster communication #1676

merged 2 commits into from Jul 3, 2023

Conversation

Altair-Bueno
Copy link
Contributor

Doesn't make much sense to block everything inside the cluster for connectivity, specially by default. You end up with confusing error responses such as this one, making it difficult to use the platform.

{
    "status": 400,
    "error": "connectivity:connection.configuration.invalid",
    "message": "The configured host 'kafka.kafka' may not be used for the connection because the host is blocked: the hostname resolved to a site local address.",
    "description": "It is a blocked or otherwise forbidden hostname which may not be used."
}

Also, the regex original regex wasn't right:

# There is no scaping on plain strings
# https://yaml.org/spec/1.2.2/#plain-style
blockedHostRegex: ^.*\.svc\.cluster\.local$

Signed-off-by: Altair-Bueno <altair.bueno@uma.es>
@Altair-Bueno Altair-Bueno changed the title fix(helm): Allow inter cluster communication fix(helm): Allow connectivity inter cluster communication Jul 3, 2023
@thjaeckle
Copy link
Member

@Altair-Bueno thanks for the PR - true .. that was a leftover from a SaaS setup where connections could be created by non-admins, but by developers using the service.

But I agree that as default this does not make sense 👍

You would also need to bump the Chart version in order to get Helm linting pass.

@thjaeckle thjaeckle added this to the 3.3.3 milestone Jul 3, 2023
Signed-off-by: Altair-Bueno <altair.bueno@uma.es>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Altair-Bueno 👍

@thjaeckle thjaeckle merged commit 7f0eb49 into eclipse-ditto:master Jul 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants