-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): fix missing whitespace in JAVA_TOOL_OPTIONS #1759
fix(helm): fix missing whitespace in JAVA_TOOL_OPTIONS #1759
Conversation
7ec4a23
to
61dd1a9
Compare
I am not sure if this is now correct to be honest ..
So adding a lot of completely blank lines - which hopefully works - I am however not quite sure/confident. Best would be of course to have each system property on a separate line to have it also more readable. |
First of all thanks for the help! |
@WatcherWhale yes, sounds good to me, let's try that first |
Signed-off-by: Mathias Maes <mathias.maes@aloxy.io>
3d8ac99
to
9a7e583
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WatcherWhale looks good now, I would approve! :)
Thanks for the contribution
In the JAVA_TOOL_OPTIONS environment variable, the different values get put together without any (white)space.
This could lead to some options not being processed by the JVM.
This PR fixes this by removing the "trim whitespace" character from the affected template.