Allow BASIC authentication for devops/status users while using Helm deployment and Ingress Controller #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important thing to note - I could not test successfully with the Seems like a akka/pekko problem. I cherry picked all commits over |
thjaeckle
reviewed
Oct 2, 2023
This specialized Ingress resource is to allow basic auth of devops path with `devops` and `status` users through Ingress Controller. Previously these paths were assigned to api Ingress, and they required ditto user credentials.
According to https://medium.com/codecademy-engineering/kubernetes-nginx-and-zero-downtime-in-production-2c910c6a5ed8 95 seconds seems like too much for ingress controller preStop shutdown.
RockyMM
force-pushed
the
feature/devops-basic-auth-ingress
branch
from
7fc93f1
to
52325c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment all
/devopsand/statuspaths are routed throughapiIngress resource. Since the introduction of BASIC auth for ditto user(s),/devopsand/statuspaths could not be authenticated with devops/status users.This PR introduces a new Ingress resource to control devops and status paths. The authorization header is simply forwarded to the gateway.
Another update is parameterizing preStop wait time on the IngressController. More info in the comments in the
values.yaml.Also Ingress Controller version is updated to 1.9.0. With this all regex-type paths are given
ImplementationSpecificpathType instead of Prefix.