Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance things search slot by displaying the amount of matching things #1864

Merged
merged 1 commit into from Jan 18, 2024

Conversation

thjaeckle
Copy link
Member

@thjaeckle thjaeckle commented Jan 16, 2024

That shows directly, how many things were matched by the filer of by the "pinned" things.

Looks like this:
image

@thfries if you could please have a look at this small enhancement? :)

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle added the UI Issues related to the Ditto explorer UI label Jan 16, 2024
@thjaeckle thjaeckle added this to the 3.5.0 milestone Jan 16, 2024
@thjaeckle thjaeckle self-assigned this Jan 16, 2024
@thfries
Copy link
Contributor

thfries commented Jan 17, 2024

Hi @thjaeckle,

nice, thank you for this extension. Looks good to me and it works. (I assume with empty filter what I see is the total amount of things?)

One thought I had:

  • I may have returned back the headline for the Things section and show the number of things there (like below). Then it would be consistent with the other collapsable sections and you would still see the number of Things if the things are collapsed. Also we would keep some more space for the filter input field. It would be overall a bit more consistent how to show "amount of items in a table". But if you see the count value as a property of the filter, it fits well like you did it. Do you expect to have the same on the new table filter?
image

@thjaeckle
Copy link
Member Author

Yes, it shows the result of the count API which takes the same RQL as the search.
If no filter is provided, it shows the total count of things your user is allowed to see.

I would therefore (as it also directly is influenced by the filter) keep it close to the filter, that's why I put it there.

In the section heading might be misleading.
For the incoming thing Mesages I think it is good. There you see when some new messages arrive.

@thfries
Copy link
Contributor

thfries commented Jan 18, 2024

Understood. I came to the same conclusion.
So I keep the new table filter as is. We may add that in future too.

Looking forward to have that merged 😀. Thank you

@thjaeckle thjaeckle merged commit f2904ef into master Jan 18, 2024
3 checks passed
@thjaeckle thjaeckle deleted the feature/add-search-count-to-ui branch January 18, 2024 06:05
@thfries
Copy link
Contributor

thfries commented Jan 19, 2024

@thjaeckle, I just realized that before there was no way to count things in the UI. Nice useful extension!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Issues related to the Ditto explorer UI
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants