Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subsystem health check to liveness checks #1867

Merged
merged 1 commit into from Jan 23, 2024
Merged

Add subsystem health check to liveness checks #1867

merged 1 commit into from Jan 23, 2024

Conversation

dimabarbul
Copy link
Contributor

Resolves #1865

@thjaeckle
Copy link
Member

Thanks a ton @dimabarbul
Will review soon.

@thjaeckle thjaeckle added this to the 3.5.0 milestone Jan 19, 2024
thjaeckle
thjaeckle approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dimabarbul
I reviewed and have nothing to add - very good (and yet simple) contribution.

LGTM 👍

@thjaeckle thjaeckle merged commit 2a35c6f into eclipse-ditto:master Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees

@dimabarbul dimabarbul

Labels
None yet
Projects
Ditto Planning
Status: Done
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

/alive and /ready health checks do not consider subsystem health
2 participants
@dimabarbul @thjaeckle