Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1839: introduce script to Helm chart updating pod-deletion-cost #1871

Merged
merged 2 commits into from Jan 26, 2024

Conversation

thjaeckle
Copy link
Member

  • script is executed as "pre-upgrade" hook and as cron-job
  • script updates the pod-deletion-cost for the "oldest" members in the Ditto cluster

Resolves: #1839

Or it should at least improve stability during cluster upgrade

@thjaeckle thjaeckle added this to the 3.5.0 milestone Jan 23, 2024
@thjaeckle thjaeckle self-assigned this Jan 23, 2024
* script is executed as "pre-upgrade" hook and as cron-job
* script updates the pod-deletion-cost for the "oldest" members in the Ditto cluster

Signed-off-by: Thomas Jäckle <thomas.jaeckle@beyonnex.io>
@thjaeckle thjaeckle force-pushed the feature/1839-pod-deletion-cost branch from e9f3f35 to 92036c2 Compare January 25, 2024 13:01
@thjaeckle
Copy link
Member Author

@alstanchev this would be ready to review - would appreciate a look :)

This basically implements what is described here https://www.lightbend.com/blog/faster-and-smoother-rolling-updates-for-akka-clusters-in-kubernetes - but purely via Helm and scripting.

@alstanchev
Copy link
Contributor

Sure no problem, @kalinkostashki can you also take a look as you are more familiar with helm than me.

Copy link
Contributor

@kalinkostashki kalinkostashki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@thjaeckle thjaeckle merged commit 4924fed into master Jan 26, 2024
9 checks passed
@thjaeckle thjaeckle deleted the feature/1839-pod-deletion-cost branch January 26, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Stabilize Ditto on k8s pod rescheduling and rolling updates
3 participants