Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to add custom annotations to podDeletionCostPatching jobs. #1902

Conversation

kyberpunk
Copy link
Contributor

@kyberpunk kyberpunk commented Feb 12, 2024

Hi. I would like to add capability for adding custom annotation to new pod deleting hook jobs in Ditto Helm chart. Main use case is to be able to adjust configuration (e.g. disabling or configuring of Istio sidecars) to make job working properly in special setups.
Thank you.

Signed-off-by: Vit Holasek <xvh@seznam.cz>
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kyberpunk

Looks good to me. 👍
Could you provide a configuration example (just in this issue) how such an Istio sidecar configuration would look like?

@thjaeckle thjaeckle added this to the 3.5.3 milestone Feb 13, 2024
@kyberpunk
Copy link
Contributor Author

kyberpunk commented Feb 13, 2024

Hi @kyberpunk

Looks good to me. 👍 Could you provide a configuration example (just in this issue) how such an Istio sidecar configuration would look like?

Sure. We need to disable Istio sidecar for this particular job, because it prevents the job from finishing (known issue of Istio sidecars).

global:
  podDeletionCostPatching:
    annotations:
      sidecar.istio.io/inject: "false"

@thjaeckle thjaeckle merged commit ffdd3de into eclipse-ditto:master Feb 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants