Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce memory consumption of ThingPersistenceActor #194

Merged
merged 55 commits into from
Jul 26, 2018
Merged

Reduce memory consumption of ThingPersistenceActor #194

merged 55 commits into from
Jul 26, 2018

Conversation

dguggemos
Copy link
Contributor

The ThingPersistenceActor handles thing commands and events using inner class strategies, which access and modify the internal state of the actor. This requires these command strategies and event handlers to be instantiated for every single persistence actor, which does not scale very well. With this PR the strategies and handlers were moved out of the persistence actor into separate packages, so that they only need to be instantiated once per actor system. This brings several improvements:

  • reduced memory consumption
  • a much smaller and cleaner ThingPersistenceActor
  • strategies and handlers can be tested independent of the actor

dguggemos and others added 30 commits July 3, 2018 09:49
@dguggemos
lazy load thing command strategies, move thing event handling to sepa…
ced458e 
…rate class
@dguggemos
lazy load strategies that handle thing commands, move handling of thi…
7bdc025 
…ng events to separate class

Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
ca04889 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
51b69dd 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
80236b8 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
ced9807 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
moved strategies out of ThingPersistenceActor
1addd38 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
moved strategies out of ThingPersistenceActor
0831f08 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
f86f65a 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
07f7b55 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
9d1c715 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
moved event handling strategies into own classes
7ac0f1c 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
Merge remote-tracking branch 'origin/bugfix/things-memory' into bugfi…
9e3b44d 
…x/things-memory

# Conflicts:
#	services/things/persistence/src/main/java/org/eclipse/ditto/services/things/persistence/actors/ThingPersistenceActor.java
javadoc
fae7b30 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
8fcf719 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
c9f3320 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
d96fde9 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
de50556 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
renamed HandleStrategy to EventStrategy
8082458 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
moved command strategies to separate package, made EventHandleStrateg…
f882f48 
…y a singleton

Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
fixed license header
6ede43d 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package
452b37e 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
[wip] move command strategies to separate package - fix javadoc
fc44612 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
temp. ignore test
09da161 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
add javadoc, tests, remove unused methods
f9f2f24 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
unignore test
ca350d9 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
added unit tests for event strategies
6c7f413 
Signed-off-by: Johannes Schneider <johannes.schneider@bosch-si.com>
Merge remote-tracking branch 'origin/bugfix/things-memory' into bugfi…
aed28ed 
…x/things-memory
@dguggemos
add more tests, introduce DelegateStrategy
8054882 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
ignore failing test again
4e74042 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
dguggemos and others added 24 commits July 10, 2018 10:00
@dguggemos
Merge branch 'master' into bugfix/things-memory
9f0778d
@dguggemos
some cleanup, javadoc
b9bdac6 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
improve javadoc, fix warnings
d798a2b 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
fix code smells
c9883ca 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
@dguggemos
fix code smells
0ed2d29 
Signed-off-by: Dominik Guggemos <dominik.guggemos@bosch-si.com>
Some refactorings:
1548d71 
* Moved methods for creating exceptions from AbstractCommandStrategy to ExceptionFactory.
* Moved ImmutableResult to ResultFactory to inhibit direct instantiation of ImmutableResult.
* Moved some files to reduce cyclic dependencies of packages.
* Added unit test for some command strategies.
* Redesigned some strategies to be more fluent and easier to understand.

Work in progress!

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Fixed Javadoc comments. Added some unit tests. Replaced weird class h…
7b05691 
…ierarchy with composition.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Added parameter to Javadoc comment.
9413c71 
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Replaced ASCII-style arrow with HTML arrow.
e599654 
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Made method static and adjusted some log statements.
67ed140 
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Reviewed event strategies: Introduced abstract implementation for han…
b7be1cf 
…dling possible null Thing and get rid of redundancy.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Added unit tests for command strategies and refactored command strate…
a8171c9 
…gies to be more fluent.

Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Directly set thing from event handling result.
1a5c237 
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
Adjusted some formatting and completed Javadoc comment.
1997b8e 
Signed-off-by: Juergen Fickel <juergen.fickel@bosch-si.com>
@dguggemos
Merge branch 'master' into bugfix/things-memory
636b9a4
@thjaeckle
enhanced travis_wait time to 30minutes
43e856d 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
increased logger startup timeout in order to fix tests on travis
cef99d8 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
added logging to test failing on Travis
bdda7f4 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
experiment with logging config in order to satisfy Travis build
6b6d798 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
try to get Travis building
2116d65 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
try to get Travis building
0a1d527 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
save object instantiation of DefaultContext for each command
2db8ae5 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle
Merge branch 'master' into bugfix/things-memory
35028b1
@yufei-cai
ThingPersistenceActor: organize CommandStrategy.Result as algebraic d…
677d249 
…atatype; enable async notification

Signed-off-by: Cai Yufei (INST/ECS1) <yufei.cai@bosch-si.com>
thjaeckle
thjaeckle approved these changes Jul 26, 2018
View reviewed changes
Copy link
Member

@thjaeckle thjaeckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool 👍
exciting times :)

@thjaeckle
review: adjusted method name
50dba8f 
Signed-off-by: Thomas Jaeckle <thomas.jaeckle@bosch-si.com>
@thjaeckle thjaeckle merged commit 1e607c3 into eclipse-ditto:master Jul 26, 2018
@thjaeckle thjaeckle deleted the bugfix/things-memory branch July 26, 2018 07:03
@thjaeckle thjaeckle added this to the 0.3.0-M3 milestone Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thjaeckle thjaeckle thjaeckle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dguggemos @thjaeckle @yufei-cai