Bugfix/password decoding #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Furthermore decode the values as URL not as HTML form url body Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
* The permission is required on the message resource and not on the thing resource Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
thjaeckle
reviewed
Mar 5, 2021
...src/main/java/org/eclipse/ditto/services/connectivity/messaging/amqp/AmqpSpecificConfig.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Yannic Klem <yannic.klem@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in AMQP password decoding.
Previously the decoding was made by using
java.net.URLDecoderwhich is meant to be used onx-www-form-urlencodedpayload.This decodes the
+character to a space.In this PR all
+characters are replaced by their encoded representation%2Bbefore calling thejava.net.URLDecoderAdditionally I've made an improvement of the error description for failure when sending messages to or from a thing.