Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If memfile_buffer_count != 0, first messages are lost #1074

Closed
KerstinKeller opened this issue Apr 18, 2023 · 3 comments
Closed

If memfile_buffer_count != 0, first messages are lost #1074

KerstinKeller opened this issue Apr 18, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@KerstinKeller
Copy link
Contributor

Problem Description

With a higher memfile_buffer_count, not all messages reach the subscriber, see the testcase in this commit:
master...hotfix/shm-buffer-count-testcase

How to reproduce

Run the provided testcase.

How did you get eCAL?

I don't know

Environment

Current master

eCAL System Information

No response

@KerstinKeller KerstinKeller added this to the eCAL 5.12 milestone Apr 21, 2023
@KerstinKeller KerstinKeller added the bug Something isn't working label Apr 21, 2023
@chengguizi
Copy link

Any update on this so far? Not sure how this would be affected by the major zero-copy change in #1082

Having a circular buffer of memfiles + zero copy would be a really great feature to have for low-latency, high-frequency, low-drop message system.

@rex-schilasky
Copy link
Contributor

@chengguizi this fix is in progress and will be part of 5.12.

@chengguizi
Copy link

Sounds good! Very look forward to an improved zero-copy implementation that also supports circular buffer (hence avoid missing messages) :)

rex-schilasky added a commit that referenced this issue May 26, 2023
number of handled memory files will be adapted by ShmSetBufferCount and not in the next Write call to get it communicated in advance to the reader side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants