-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto messages with default values aren't transmitted by eCAL::protobuf::CPublisher<T>
#397
Comments
I believe this check may be where this behavior is stemming from: https://github.com/continental/ecal/blob/962c8340720fe51c4e1f8aa0e8ed3d15075e881e/ecal/core/src/pubsub/ecal_publisher.cpp#L269 |
This is a known behavior. In the case of a zero-length message the underlaying API is not initiating the publication. In this specific context (zero length default google message). Thank you for the feedback we need to check how we can fix that. |
…transport will be forced with a minimal message of 1 byte
@FlorianReimold can you please apply this fix to the next 3.9.x release ? |
…transport will be forced with a minimal message of 1 byte (#398) please cherry pick to at least 5.9.1
@bsirang fix is available on master, will be part of next release. |
…transport will be forced with a minimal message of 1 byte (#398) please cherry pick to at least 5.9.1
…transport will be forced with a minimal message of 1 byte (#398) please cherry pick to at least 5.9.1
Describe the bug
A default proto message, which has default values for all fields, doesn't seem to be sent over the wire.
To Reproduce
eCAL::protobuf::CPublisher<T>
T
Send()
method with the default proto messageExpected behavior
The subscribers would receive the message. I understand protobufs do not serialize the default values over the wire thus the serialized proto payload would be zero-length in this case. However, in these cases, I'm expecting the subscriber to still receive the message.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: