Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto messages with default values aren't transmitted by eCAL::protobuf::CPublisher<T> #397

Closed
bsirang opened this issue Sep 9, 2021 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@bsirang
Copy link
Contributor

bsirang commented Sep 9, 2021

Describe the bug
A default proto message, which has default values for all fields, doesn't seem to be sent over the wire.

To Reproduce

  1. Create a eCAL::protobuf::CPublisher<T>
  2. Default construct the proto message T
  3. Call the Send() method with the default proto message
  4. Observe subscribers do not receive anything

Expected behavior
The subscribers would receive the message. I understand protobufs do not serialize the default values over the wire thus the serialized proto payload would be zero-length in this case. However, in these cases, I'm expecting the subscriber to still receive the message.

Desktop (please complete the following information):

  • OS: Ubuntu
  • Version 20.04
@bsirang
Copy link
Contributor Author

bsirang commented Sep 9, 2021

@rex-schilasky rex-schilasky self-assigned this Sep 10, 2021
@rex-schilasky rex-schilasky added the bug Something isn't working label Sep 10, 2021
@rex-schilasky
Copy link
Contributor

This is a known behavior. In the case of a zero-length message the underlaying API is not initiating the publication. In this specific context (zero length default google message). Thank you for the feedback we need to check how we can fix that.

rex-schilasky added a commit that referenced this issue Sep 10, 2021
…transport will be forced with a minimal message of 1 byte
@rex-schilasky
Copy link
Contributor

@FlorianReimold can you please apply this fix to the next 3.9.x release ?

rex-schilasky added a commit that referenced this issue Sep 10, 2021
…transport will be forced with a minimal message of 1 byte (#398)

please cherry pick to at least 5.9.1
@rex-schilasky
Copy link
Contributor

@bsirang fix is available on master, will be part of next release.

FlorianReimold pushed a commit that referenced this issue Sep 15, 2021
…transport will be forced with a minimal message of 1 byte (#398)

please cherry pick to at least 5.9.1
FlorianReimold pushed a commit that referenced this issue Sep 15, 2021
…transport will be forced with a minimal message of 1 byte (#398)

please cherry pick to at least 5.9.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants