New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMsgPublisher::SendSynchronized method added #1026
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment.
} | ||
return(0); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmhm, this implementation looks a bit strange to me, but I guess the regular implementation is similar.
However, if the size = 0
, it is not sending synchronized, but shouldn't it? Even if no data was transferred, the receiver should still acknowledge that it has been signaled?
clang-tidy review says "All clean, LGTM! 👍" |
…d CMsgPublisher::SendSynchronized() call add time_ parameter to to zero length payload CMsgPublisher::Send() call
clang-tidy review says "All clean, LGTM! 👍" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Pull request type
Please check the type of change your PR introduces:
Issue Number: #1025