CMake: Remove dirty find_package hack. #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yay! 🎉 It was minorly annoying when I was doing the vcpkg port, ended up just disabling it I can have a go at testing against this PR, at some point, and let you know if it works well. 😄 |
|
Yesterday, when we tested it, we still got issues with asio. Thus, I degraded this PR to a Draft. We will merge it once the issues are fixed. There will also be a PR for the master branch. |
|
@FlorianReimold The problem was different, the patch we provided didn't include the last two commits on this PR. This is ready to be merged... |
|
@DownerCase you can give it a try with vcpkg if you like |
FlorianReimold
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
find_packageoverwriting is removedCherry-pick to
5.11 (old stable) - If applicable - not 100% necessary