Python: Fix client remove response callback #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KerstinKeller: Can you check on this? It does change the API, but honestly I think that there is no point in keeping it stable when it never worked. |
FlorianReimold
approved these changes
Nov 28, 2023
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 19, 2024
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 19, 2024
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 23, 2024
FlorianReimold
pushed a commit
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the python bindings for removing a response callback from a service client:
ecal.core.service.py:rem_response_callbacktaking a method name parameter (which was unused) and calling non-existantecal.core.core.client_rem_response_callback.ecal.core.core.py:client_rem_response_callbackdoesn't exist because it was typoed in asclient_rem_method_callback.ecal_wrap.cxx:client_rem_response_callbackdoes exist_ecal_methodsmapping binds the python API functionclient_rem_response_callbackto the C++ functionclient_add_response_callback!Related issues
Cherry-pick to