Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrapper function miss matching #1285

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Conversation

GJYang
Copy link
Contributor

@GJYang GJYang commented Dec 20, 2023

Description

Fix python wrapper function name
client_set_host_name to client_set_hostname

the method defined here:
https://github.com/eclipse-ecal/ecal/blob/28ef1a150bf7e27d0748c124d42a7381f72c4862/lang/python/core/src/ecal_wrap.cxx#L1633C22-L1633C22

Related issues

Cherry-pick to

  • 5.11
  • 5.12

Copy link
Contributor

@hannemn hannemn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing this fix @GJYang and you are totally right here. We made the underlying wrapper call accidentally with a small typo.

@hannemn hannemn enabled auto-merge (squash) December 20, 2023 11:16
@hannemn hannemn merged commit 5e3d6b6 into eclipse-ecal:master Dec 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants