ensure correct udp socket concurrent handling by mutex #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorianReimold
approved these changes
Jan 9, 2024
rex-schilasky
added a commit
that referenced
this pull request
Jan 18, 2024
* ensure correct udp socket concurrent handling by mutex (#1289) * Doc: Downgraded sphinx related packages in requirements.txt (#1302) (#1309) * The most recent release of various sphinx related packages need Sphinx 5 or up, but our old sphinx-book-theme 0.3.3 requires Sphinx 4 For a proper solution see #1303 --------- Co-authored-by: KerstinKeller <KerstinKeller@users.noreply.github.com> Co-authored-by: Florian Reimold <11774314+FlorianReimold@users.noreply.github.com>
KerstinKeller
added a commit
that referenced
this pull request
Feb 5, 2024
This reverts commit 771280e.
FlorianReimold
added a commit
that referenced
this pull request
Feb 6, 2024
This reverts commit 771280e.
FlorianReimold
added a commit
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sporadic crashing of UDP layer shutdown (triggered by eCAL::Finalize ) by resetting the socket while still handling receives. Socket needs to be protected by mutex.