[core] add/improved IsPublished/IsSubscribed logic (5.13.x) #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IsSubscribed" (we may rename both functions to "IsConnected" in the future) new additional check for IsPublished using the connection state of the matching subscriber (should ensure that IsPublished is flagged as true only if publisher is able to send data) test added to test new behavior
rex-schilasky
changed the title
| @@ -295,8 +295,12 @@ namespace eCAL | |||
|
|
|||
| iter->second->ApplyLocLayerParameter(process_id, topic_id, tlayer.type(), writer_par); | |||
| } | |||
| // inform for local publisher connection | |||
| iter->second->ApplyLocPublication(process_id, topic_id, topic_info); | |||
| // we only inform the subscriber when the publisher has already recognized at least on local subscriber | |||
There was a problem hiding this comment.
at least on -> at least one
| @@ -345,8 +349,12 @@ namespace eCAL | |||
| const std::string writer_par = tlayer.par_layer().SerializeAsString(); | |||
| iter->second->ApplyExtLayerParameter(host_name, tlayer.type(), writer_par); | |||
| } | |||
| // inform for external publisher connection | |||
| iter->second->ApplyExtPublication(host_name, process_id, topic_id, topic_info); | |||
| // we only inform the subscriber when the publisher has already recognized at least on external subscriber | |||
There was a problem hiding this comment.
At least on -> at least one
…compatibility within 5.13.x
KerstinKeller
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues