Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] add/improved IsPublished/IsSubscribed logic (5.12.x) #1634

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

rex-schilasky
Copy link
Contributor

Description

  • additional check for CSubscriber::GetPublisherCount() using the connection state of the matching subscriber to ensure that GetPublisherCount is increased only if the matching publisher is able to send data
  • test added to test new behavior

Related issues

…nection state of the matching subscriber (should ensure that GetPublisherCount is increased only if connected publisher is able to send data)

test added to test new behavior
Copy link
Contributor

@KerstinKeller KerstinKeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rex-schilasky rex-schilasky merged commit 799dcd1 into support/v5.12 Jun 20, 2024
15 of 16 checks passed
@rex-schilasky rex-schilasky deleted the hotfix/pub_sub_state_logic_5_12 branch June 20, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants