Added Memory Mapped Files, Tests and much more #58

FlorianReimold · 2023-11-02T12:01:02Z

Performance improvements for FTP Downloads through memory-mapped file (Thanks to @bjuulp)
Added googletest as submodule
Added unit tests for fineftp-server. The tests require C++17 to compile and curl to be present in the PATH when executing them
New CMake Options for Enabling / Disabling different components (See Readme.md)
Binary downloads for Windows are now built with VS 2017 / v140 toolset
Fixed a race condition on Windows that caused files not being fully flushed after fineftp-server reported the finished data upload (Thanks to @bjuulp)
Reordered internal asio::strand implementation in order to prevent race conditions that haven't been detected, yet. (Thanks to @bjuulp)
Fixed a vulnerability that enabled an attacker to access files above the root directory (reported by [Vulnerability] Path traversal results in an arbitrary file read/write #52)
Fixed many clang-tidy warnings
The APPE (= append-to-file) command now creates a new file if it didn't exist already (this is the correct behavior according to RFC 959
Updated the asio submodule to 1.28.2

…into test/memory_mapped_files

…eftp-server into test/memory_mapped_files

Relative path check fix

…eftp-server into test/memory_mapped_files

- Added Test for LIST command and standalone RENAME command - The data socket is now properly closed before sending 226 Done. This fixes an issue with curl, which complained about connections resets.

…ility Test for now

This makes it easier to use code-coverage tools from the operating system

Improved documenation of strands

…pse-ecal/fineftp-server into feature/memory_mapped_files

…between windows and Posix

bjuulp and others added 30 commits April 14, 2023 18:33

Eliminate compile time warning

8633001

Use mem mapped files when sending

113c4c2

Added gtest submodule

431d196

GH Actions: enabled tests on windows

d0a9216

Fixed cmake parameters

08bb1f1

Hopefully fixed path issues

e49b6f9

Added missing file and removed it from the .gitignore

ff79a10

Added *.vscode to gitignore

3589743

Fixed path for testing

c7edba3

Only run tests on static builds

de79ed7

Only build tests for static builds

342af7e

Fixed tests for shared lib builds

adac9f4

Added testing for Ubuntu and macOS

fb483a3

switched macos to bash

5152e02

Added the first actual test

67a5975

Switched to VS2017 on Windows in order to compile the tests

d9364a8

Added some Tests

2014999

Merge branch 'memmapfiles' of https://github.com/bjuulp/fineftp-server …

c056080

…into test/memory_mapped_files

Added Test for UTF8 Files

dc1e815

Merge branch 'feature/testing' of https://github.com/eclipse-ecal/fin…

15dcefe

…eftp-server into test/memory_mapped_files

Remove redundant path checks

af1e7dd

Fix UTF-8 path support

a9ef242

Added Test that exposes the Relative-Path-vulnerability

0efb99f

Merge pull request #53 from bjuulp/relative_path_check_fix

50a304d

Relative path check fix

Merge branch 'feature/testing' of https://github.com/eclipse-ecal/fin…

04b9455

…eftp-server into test/memory_mapped_files

Added test and fixed problem

5978aaa

- Added Test for LIST command and standalone RENAME command - The data socket is now properly closed before sending 226 Done. This fixes an issue with curl, which complained about connections resets.

Reduce scope of ifstream

20ea79d

Add strand wrapping when receiving data

d432a22

Add Win32 specific writeable file

c1a0919

Make it easier to see reason for test failure

c1074b0

FlorianReimold and others added 23 commits October 24, 2023 16:57

Fixed Win32 writable file, added more tests and removed Path Vulnerab…

02fd0de

…ility Test for now

Improved README.md

1801294

Added Support for APPE again (and fixed the Win32 code to support it)

6117e1a

Improved documenation of strands

5ba2057

Added option to not use the builtin googletest.

3860039

This makes it easier to use code-coverage tools from the operating system

Merge pull request #57 from bjuulp/improved_strand_doc

b20ec59

Improved documenation of strands

Fixed path vulnerability and enabled test for it

62a8e2c

Fixed compile issue on Ubuntu

1d0649f

Added some more tests for testing FTP Permissions

64d9faa

Merge branch 'feature/memory_mapped_files' of https://github.com/ecli…

51c2cc1

…pse-ecal/fineftp-server into feature/memory_mapped_files

Added more tests and fixed APPE command

29e1210

Fixed test on ubuntu

346acb7

Added even more tests

9222318

Implemented my own system_execute command to work around differences …

bd275d6

…between windows and Posix

Added more tests

9ed680f

Fixed test on Ubuntu

f4e71e5

Added basic tests for LIST and NLST

b1eb681

Implemented the QUIT command properly

2b851e0

Fixed many warnings and updated asio

a7a7932

Fixed clang-tidy warnings on ubuntu

c148060

Fixed as many clang-tidy include warnings as possible

9802434

Fixed a compile issue on windows

ab6e47d

Bumped version number to 1.4.0

11953fe

FlorianReimold marked this pull request as ready for review November 2, 2023 15:06

FlorianReimold merged commit 4e8ae35 into master Nov 2, 2023
18 of 19 checks passed

This was referenced Nov 2, 2023

Add Tests to fineftp-server #50

Closed

Add gtest as submodule. #51

Closed

[Vulnerability] Path traversal results in an arbitrary file read/write #52

Closed

Immediate Rename of uploaded file sometimes fails on Windows #54

Closed

FlorianReimold deleted the feature/memory_mapped_files branch March 1, 2024 09:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Memory Mapped Files, Tests and much more #58

Added Memory Mapped Files, Tests and much more #58

FlorianReimold commented Nov 2, 2023 •

edited

Added Memory Mapped Files, Tests and much more #58

Added Memory Mapped Files, Tests and much more #58

Conversation

FlorianReimold commented Nov 2, 2023 • edited

FlorianReimold commented Nov 2, 2023 •

edited