Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: switch ContractValidationService usages to the new methods #3877

Closed
ndr-brt opened this issue Feb 19, 2024 · 0 comments · Fixed by #3878
Closed

refactor: switch ContractValidationService usages to the new methods #3877

ndr-brt opened this issue Feb 19, 2024 · 0 comments · Fixed by #3878
Assignees
@ndr-brt
Labels
refactoring Cleaning up code and dependencies
Milestone
Milestone 14

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Feb 19, 2024

Feature Request

In #3854 new methods were added on ContractValidationService that accept ParticipantAgent instead of ClaimToken, we should switch to use the first ones and remove the ParticipantAgentService collaborator from the ContractValidationServiceImpl.

Which Areas Would Be Affected?

validation

Why Is the Feature Desired?

refactoring

Solution Proposal

If possible, provide a (brief!) solution proposal.
@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Feb 19, 2024
@ndr-brt ndr-brt added this to the Milestone 14 milestone Feb 19, 2024
@ndr-brt ndr-brt self-assigned this Feb 19, 2024
@ndr-brt ndr-brt mentioned this issue Feb 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndr-brt ndr-brt

Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Milestone
Milestone 14
Development

Successfully merging a pull request may close this issue.

refactor: cleanup ContractValidationService Think-iT-Labs/edc-connector
1 participant
@ndr-brt