feat(dsp): add negotiations/offer endpoint
#3854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
added
enhancement
ndr-brt
requested review from
paullatzelsperger,
ronjaquensel and
juliapampus
as code owners
ndr-brt
force-pushed
the
3840-add-negotiation-offers-endpoint
branch
2 times, most recently
from
c6b9dd5
to
4b8fff5
Compare
jimmarino
approved these changes
Feb 19, 2024
ndr-brt
force-pushed
the
3840-add-negotiation-offers-endpoint
branch
from
4b8fff5
to
721d2be
Compare
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add the
negotiations/offerendpoint, that can be used by a provider to start a negotiation.Why it does that
dsp compliance
Further notes
ContractOfferMessageI had to move the extraction of the counter party id from the contract validator to theProtocolTokenValidator, that returns aServiceResult<ParticipantAgent>now. I left the old methods and I will align the missing services (transfer process and catalog) to the new behavior in a subsequent PR.ContractRequestMessagefor thecallbackAddressproperty to the JsonLdValidator instance, because it didn't make much sense in the controller (and it wasn't properly tested too).Linked Issue(s)
Closes #3840
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.