Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management Domains: Asset and Dataset specialization pt. 1 #4295

Closed
paullatzelsperger opened this issue Jun 21, 2024 · 0 comments · Fixed by #4297
Closed

Management Domains: Asset and Dataset specialization pt. 1 #4295

paullatzelsperger opened this issue Jun 21, 2024 · 0 comments · Fixed by #4297
Assignees
Labels
api Feature related to the (REST) api core feature enhancement New feature or request
Milestone

Comments

@paullatzelsperger
Copy link
Member

paullatzelsperger commented Jun 21, 2024

Feature Request

As part one of the implementation of management domains this issue is about changes to the Asset class.

Changes to the Asset class

Specifically, Assets will receive a method boolean isCatalog() that indicates, whether an Asset is a catalog asset (i.e. refers to another remote catalog) or not.
This information is stored and persisted as a boolean flag in the privateProperties of an Asset.

Changes to the Management API

  • ingress: when an Asset's has a @type: edc:CatalogAsset set, then the aforementioned boolean flag isCatalog is set to true. Naturally, it is also possible to omit the @type: edc:CatalogAsset, and directly set the flag when creating the Asset.
  • egress: when an Asset#privateProperties contains the boolean flag isCatalog: true, then the transformer sets the Asset's @type: edc:CatalogAsset.

The reason for this duplication is that EDC does not persist the @type field. Conversely, the privateProperties are not serialized over DSP.

Which Areas Would Be Affected?

Management API, Asset data model

Why Is the Feature Desired?

to enable the implementation Management Domains, in particular linked catalogs

Solution Proposal

  • this change should not break existing management API client implementations!
@paullatzelsperger paullatzelsperger added api Feature related to the (REST) api core feature enhancement New feature or request labels Jun 21, 2024
@paullatzelsperger paullatzelsperger added this to the Milestone 16 milestone Jun 21, 2024
@paullatzelsperger paullatzelsperger self-assigned this Jun 21, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Jun 21, 2024
@paullatzelsperger paullatzelsperger removed the triage all new issues awaiting classification label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api core feature enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant