Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement Asset specialization #4297

Conversation

paullatzelsperger
Copy link
Member

@paullatzelsperger paullatzelsperger commented Jun 21, 2024

What this PR changes/adds

  • added a method Asset#isCatalog()
  • Management API ingress: JSON-LD transformers parse the @type field and set the Asset#properties['isCatalog'] flag
  • Management API egress: JSON-LD transformers set the @type field on egress if Asset#properties['isCatalog'] is true
  • the information whether an Asset is a CatalogAsset is stored in Asset#properties

Why it does that

prepare for the next iteration, where Dataset extends Catalog

Further notes

  • I had originally planned to store the information in the privateProperties, but that would have made querying for CatalogAssets impossible, because we currently can't query by private properties. If we don't care about querying, I'd suggest moving the flag back to the privateProperties
  • the EqualOperatorPredicate can now handle booleans

Linked Issue(s)

Closes #4295

Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.

@paullatzelsperger paullatzelsperger added enhancement New feature or request core feature api Feature related to the (REST) api labels Jun 21, 2024
@paullatzelsperger paullatzelsperger marked this pull request as ready for review June 21, 2024 10:39
@paullatzelsperger paullatzelsperger force-pushed the feat/4295_implement_asset_specialization branch from ee2789c to 4200923 Compare June 21, 2024 11:02
@paullatzelsperger paullatzelsperger merged commit 44299d4 into eclipse-edc:main Jun 24, 2024
22 of 24 checks passed
@paullatzelsperger paullatzelsperger deleted the feat/4295_implement_asset_specialization branch June 24, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Feature related to the (REST) api core feature enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Management Domains: Asset and Dataset specialization pt. 1
2 participants