Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Report for tagged tests #1115

Merged
merged 1 commit into from Apr 13, 2022

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

  • Create a composite action for a generic task to run tests + upload test report XMLs as artifacts
  • Merge the two workflows for UT and IT into one (required for the item below)
  • Organize the workflow to run UT and ITs in several parallel jobs, and then a final job that combines the result XMLs into one report

Why it does that

GitHub PR test report previously contains only unit tests. With this PR it also includes integration tests.

Further notes

Also merged the two jobs running AWS integration tests into one.

See sample PR with a failing test, showing the report related actions are also executed in that case: agera-edc#212

Linked Issue(s)

Closes #1046

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@algattik algattik changed the title CI: test reports CI: Report for tagged tests Apr 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1115 (33a8107) into main (70ff63d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1115      +/-   ##
============================================
- Coverage     62.61%   62.61%   -0.01%     
  Complexity     2969     2969              
============================================
  Files           694      694              
  Lines         15416    15416              
  Branches       1044     1044              
============================================
- Hits           9653     9652       -1     
  Misses         5334     5334              
- Partials        429      430       +1     
Impacted Files Coverage Δ
.../dataspaceconnector/boot/util/TopologicalSort.java 92.85% <0.00%> (-2.39%) ⬇️
...main/contract/negotiation/ContractNegotiation.java 0.00% <0.00%> (ø)
...e/selector/api/DataplaneSelectorApiController.java 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ff63d...33a8107. Read the comment docs.

@algattik algattik marked this pull request as ready for review April 12, 2022 08:49
@algattik algattik requested review from ndr-brt and paullatzelsperger and removed request for ndr-brt April 12, 2022 11:45
@paullatzelsperger paullatzelsperger removed their request for review April 13, 2022 05:26
@paullatzelsperger
Copy link
Member

removing myself as reviewer since @ndr-brt already reviewed it.

@mspiekermann mspiekermann added this to In progress in Connector via automation Apr 13, 2022
@algattik
Copy link
Contributor Author

@juliapampus @jimmarino this PR is OK to merge, thanks

@juliapampus juliapampus merged commit 59aefa1 into eclipse-edc:main Apr 13, 2022
Connector automation moved this from In progress to Done Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Report for tagged tests
5 participants