Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add checkstyle rule for StaticVariableName #1165

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

Add a rule for checkstyle check StaticVariableName.
Checks that static, non-final variable names conform to a specified pattern.

Why it does that

Improve code consistency and reduce spurious PR diffs.

Further notes

Some fixes involved making variables final that are used as final.

Linked Issue(s)

Relates to #991

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1165 (db126d2) into main (045c9a6) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##               main    #1165   +/-   ##
=========================================
  Coverage     62.65%   62.65%           
  Complexity     2981     2981           
=========================================
  Files           694      694           
  Lines         15428    15428           
  Branches       1048     1048           
=========================================
+ Hits           9666     9667    +1     
  Misses         5331     5331           
+ Partials        431      430    -1     
Impacted Files Coverage Δ
...taspaceconnector/boot/monitor/MonitorProvider.java 0.00% <0.00%> (ø)
.../dataspaceconnector/boot/util/TopologicalSort.java 95.23% <0.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 045c9a6...db126d2. Read the comment docs.

@algattik algattik marked this pull request as ready for review April 19, 2022 08:41
@bscholtes1A bscholtes1A merged commit a0cf2a2 into eclipse-edc:main Apr 21, 2022
@juliapampus juliapampus added this to In progress in Connector via automation Apr 29, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants