Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add checkstyle rule for RedundantModifier #1166

Conversation

algattik
Copy link
Contributor

What this PR changes/adds

Add a rule for checkstyle check RedundantModifier.
Checks for redundant modifiers, such as usage of public and abstract for method declarations in interfaces, or public constructor in private static classes.

Why it does that

Improve code consistency and reduce spurious PR diffs.

Further notes

Linked Issue(s)

Relates to #991

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #1166 (38ea08b) into main (79b58b8) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@             Coverage Diff              @@
##               main    #1166      +/-   ##
============================================
- Coverage     58.45%   58.44%   -0.01%     
+ Complexity     2726     2725       -1     
============================================
  Files           698      698              
  Lines         15464    15464              
  Branches       1047     1047              
============================================
- Hits           9039     9038       -1     
  Misses         6002     6002              
- Partials        423      424       +1     
Impacted Files Coverage Δ
...taspaceconnector/boot/monitor/MonitorProvider.java 0.00% <0.00%> (ø)
...description/AbstractDescriptionRequestHandler.java 51.35% <ø> (ø)
.../control/HttpApiKeyAuthContainerRequestFilter.java 81.25% <ø> (ø)
...aspaceconnector/aws/dataplane/s3/S3DataSource.java 50.00% <0.00%> (ø)
...ceconnector/core/base/policy/PolicyEngineImpl.java 81.35% <100.00%> (ø)
...ids/core/transform/IdsTransformerRegistryImpl.java 65.21% <100.00%> (ø)
...connector/api/auth/BasicAuthenticationService.java 97.05% <100.00%> (ø)
...aceconnector/azure/cosmos/dialect/LimitClause.java 100.00% <100.00%> (ø)
...ceconnector/azure/cosmos/dialect/OffsetClause.java 100.00% <100.00%> (ø)
...econnector/azure/cosmos/dialect/OrderByClause.java 81.81% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b58b8...38ea08b. Read the comment docs.

@algattik algattik marked this pull request as ready for review April 19, 2022 08:41
@algattik algattik force-pushed the feature/991-checkstyle-RedundantModifier branch from 96a0b47 to 38ea08b Compare April 24, 2022 16:49
@bscholtes1A bscholtes1A merged commit 6af6804 into eclipse-edc:main Apr 25, 2022
@juliapampus juliapampus added this to In progress in Connector via automation Apr 29, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector Apr 29, 2022
@algattik algattik deleted the feature/991-checkstyle-RedundantModifier branch June 22, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants