Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add policy store to ids launcher #1209

Merged

Conversation

ronjaquensel
Copy link
Contributor

@ronjaquensel ronjaquensel commented Apr 25, 2022

What this PR changes/adds

Adds the in-memory PolicyStore to the ids-connector launcher.

Why it does that

A PolicyStore is required by the data management API, therefore the launcher currently fails to start.

Linked Issue(s)

Closes #1203

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1209 (638bab4) into main (79b58b8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1209   +/-   ##
=========================================
  Coverage     58.45%   58.45%           
  Complexity     2726     2726           
=========================================
  Files           698      698           
  Lines         15464    15464           
  Branches       1047     1047           
=========================================
  Hits           9039     9039           
  Misses         6002     6002           
  Partials        423      423           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b58b8...638bab4. Read the comment docs.

@bscholtes1A
Copy link
Contributor

Hi @ronjaquensel
looks good.
does it close #1203 ?

@ronjaquensel
Copy link
Contributor Author

Hi @bscholtes1A, hadn't seen that issue yet, thanks for the hint. It solves part of the issue. Let me add the port to the Dockerfile as well, then it should solve the whole issue.

@bscholtes1A bscholtes1A merged commit ed4991c into eclipse-edc:main Apr 25, 2022
@juliapampus juliapampus added this to In progress in Connector via automation Apr 29, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector Apr 29, 2022
@juliapampus juliapampus deleted the chore/ids-launcher-policy-store branch December 12, 2022 13:10
@juliapampus juliapampus restored the chore/ids-launcher-policy-store branch December 12, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

ids-connector launcher status
3 participants