New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: provide in-mem implementations by default #1223
Merged
bscholtes1A
merged 4 commits into
eclipse-edc:main
from
paullatzelsperger:feature/1130_default_implementations_inmem
Apr 30, 2022
Merged
Feature: provide in-mem implementations by default #1223
bscholtes1A
merged 4 commits into
eclipse-edc:main
from
paullatzelsperger:feature/1130_default_implementations_inmem
Apr 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullatzelsperger
requested review from
jimmarino and
juliapampus
as code owners
April 27, 2022 11:56
paullatzelsperger
force-pushed
the
feature/1130_default_implementations_inmem
branch
from
April 27, 2022 12:04
f56a452
to
16f5313
Compare
Codecov Report
@@ Coverage Diff @@
## main #1223 +/- ##
============================================
+ Coverage 58.94% 59.08% +0.14%
- Complexity 2815 2818 +3
============================================
Files 713 706 -7
Lines 15634 15612 -22
Branches 1049 1049
============================================
+ Hits 9215 9224 +9
+ Misses 5996 5966 -30
+ Partials 423 422 -1
Continue to review full report at Codecov.
|
bscholtes1A
approved these changes
Apr 27, 2022
...es/other/run-from-junit/src/test/java/org/eclipse/dataspaceconnector/junit/EndToEndTest.java
Show resolved
Hide resolved
ndr-brt
reviewed
Apr 28, 2022
...ase/src/main/java/org/eclipse/dataspaceconnector/core/defaults/DefaultServicesExtension.java
Outdated
Show resolved
Hide resolved
paullatzelsperger
force-pushed
the
feature/1130_default_implementations_inmem
branch
2 times, most recently
from
April 28, 2022 15:55
c652931
to
b1e71a5
Compare
ronjaquensel
approved these changes
Apr 29, 2022
paullatzelsperger
force-pushed
the
feature/1130_default_implementations_inmem
branch
from
April 29, 2022 08:03
b94ad6b
to
cf5fb14
Compare
ndr-brt
reviewed
Apr 29, 2022
...ase/src/main/java/org/eclipse/dataspaceconnector/core/defaults/DefaultServicesExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
reviewed
Apr 29, 2022
...ase/src/main/java/org/eclipse/dataspaceconnector/core/defaults/DefaultServicesExtension.java
Outdated
Show resolved
Hide resolved
ndr-brt
approved these changes
Apr 29, 2022
paullatzelsperger
force-pushed
the
feature/1130_default_implementations_inmem
branch
from
April 29, 2022 16:46
bbbc1df
to
81f3c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
All in-memory implementations of various stores are now provided as default (using the
@Provider
annotation). This means that it is not necessary anymore to add dependencies onto:extensions:in-memory:xyzstore
anymore.Why it does that
Having all those in-memory extensions had a couple of major downsides:
in-memory:
-modulesWith this PR, sane defaults are provided at all times, reducing user error and erroneous build configurations.
Further notes
AssetIndex
,ContractDefinitionStore
etc. are now provided through the new:core:defaults
module, which:core:base
depends on. It is therefore sufficient to add:core:base
, and a default (=in-mem) impl will be registered if no other impl is found on the classpath.:extensions:catalog:federated-catalog-cache
:extensions:iam:decentralized-identity:identity-did-core
Linked Issue(s)
Closes #1130
Checklist
no-changelog
)