Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: the base criterion converter can interpret lists of values for IN #1284

Conversation

paullatzelsperger
Copy link
Member

What this PR changes/adds

The BaseCriterionConverter now tries to interpret the right-hand value of an IN expression as list, and throws an exception otherwise.

Why it does that

To ensure consistent behaviour with CosmosDB- and SQL implementations.

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@paullatzelsperger paullatzelsperger force-pushed the bugfix/in_operator_for_inmem_assetindex branch from 8b74df8 to 7c6e5d1 Compare May 11, 2022 13:05
@codecov-commenter
Copy link

Codecov Report

Merging #1284 (bed8f0a) into main (508b591) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1284   +/-   ##
=======================================
  Coverage   67.35%   67.36%           
=======================================
  Files         715      715           
  Lines       15735    15743    +8     
  Branches     1043     1044    +1     
=======================================
+ Hits        10599    10605    +6     
- Misses       4652     4654    +2     
  Partials      484      484           
Impacted Files Coverage Δ
...r/spi/query/BaseCriterionToPredicateConverter.java 100.00% <100.00%> (ø)
...e/dataspaceconnector/catalog/cache/LoaderImpl.java 23.07% <0.00%> (-4.20%) ⬇️
...tor/catalog/store/InMemoryFederatedCacheStore.java 100.00% <0.00%> (ø)
.../catalog/cache/FederatedCatalogCacheExtension.java 80.32% <0.00%> (ø)
...nector/catalog/cache/loader/LoaderManagerImpl.java 89.65% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 508b591...bed8f0a. Read the comment docs.

@paullatzelsperger paullatzelsperger merged commit 0c3c873 into eclipse-edc:main May 11, 2022
@juliapampus juliapampus added this to In progress in Connector via automation May 23, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants