Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: make ContractDefinitionService find definition by its id #1325

Merged
merged 3 commits into from May 23, 2022
Merged

core: make ContractDefinitionService find definition by its id #1325

merged 3 commits into from May 23, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 18, 2022

What this PR changes/adds

ContractDefinitionService is currently getting all the definitions and then filter them in memory, this PR makes it use the ContractDefinitionStore.findById method directly

Why it does that

Improve performances

Further notes

Linked Issue(s)

Closes #1172

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@ndr-brt ndr-brt requested review from jimmarino, paullatzelsperger and juliapampus and removed request for jimmarino and paullatzelsperger May 18, 2022 10:25
@juliapampus juliapampus added this to In progress in Connector via automation May 19, 2022
Connector automation moved this from In progress to Review in progress May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #1325 (fa31027) into main (1608edd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
- Coverage   67.59%   67.59%   -0.01%     
==========================================
  Files         719      719              
  Lines       15879    15878       -1     
  Branches     1045     1045              
==========================================
- Hits        10734    10733       -1     
  Misses       4670     4670              
  Partials      475      475              
Impacted Files Coverage Δ
.../contract/offer/ContractDefinitionServiceImpl.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1608edd...fa31027. Read the comment docs.

@ndr-brt ndr-brt merged commit 8011fdd into eclipse-edc:main May 23, 2022
Connector automation moved this from Review in progress to Done May 23, 2022
@ndr-brt ndr-brt deleted the feature/1172-contract-service-by-id branch May 23, 2022 07:06
juliapampus pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Improvement: ContractDefinitionServiceImpl should query CDs by ID
4 participants