Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove services from @Provides that are already provided by @Provider #1336

Merged
merged 2 commits into from May 23, 2022
Merged

core: remove services from @Provides that are already provided by @Provider #1336

merged 2 commits into from May 23, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented May 20, 2022

What this PR changes/adds

remove services from @Provides that are already provided by @Provider

Why it does that

To avoid a warning message on startup

Further notes

superseds #1318

Linked Issue(s)

Closes #1317

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #1336 (ab9c31d) into main (8011fdd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1336   +/-   ##
=======================================
  Coverage   67.59%   67.59%           
=======================================
  Files         719      719           
  Lines       15878    15878           
  Branches     1045     1045           
=======================================
  Hits        10733    10733           
  Misses       4670     4670           
  Partials      475      475           
Impacted Files Coverage Δ
...dataspaceconnector/core/CoreServicesExtension.java 91.48% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8011fdd...ab9c31d. Read the comment docs.

@ndr-brt ndr-brt merged commit 8f13348 into eclipse-edc:main May 23, 2022
@juliapampus juliapampus added this to In progress in Connector via automation May 23, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector May 23, 2022
juliapampus pushed a commit to FraunhoferISST/edc-connector that referenced this pull request May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Warning about missing service registrations
3 participants