Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ids policy extension #1348

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented May 23, 2022

What this PR changes/adds

Removes sample module :extensions:policy:ids-policy. Adds it as developer documentation.

Why it does that

As discussed in #1114, this was something added to show how to register functions on the policy engine without any further uses.

Further notes

Maybe we have to take a further look on how this could be integrated in a more comprehensive policy documentation.

Linked Issue(s)

Closes #1156

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@juliapampus juliapampus added this to In progress in Connector via automation May 23, 2022
@juliapampus juliapampus requested a review from ndr-brt as a code owner May 23, 2022 14:09
@juliapampus juliapampus force-pushed the refactor/remove_ids-policy_extension branch from 9e67fcf to f7edc1b Compare May 23, 2022 14:10
@juliapampus juliapampus changed the title Refactor/remove ids policy extension refactor: remove ids policy extension May 23, 2022
@@ -0,0 +1,248 @@
# Policy Engine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably gets out of the scope here since it concerns "how to set up an extension" (that's missing from the doc currently), but since there are the details on how to set up the build file, probably we need to specify that a ServiceExtension file in the META-INF/services directory is needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this part and link to the "how to set up an extension" as soon as this is available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndr-brt I applied your feedback.

docs/developer/policy-engine.md Outdated Show resolved Hide resolved
docs/developer/policy-engine.md Outdated Show resolved Hide resolved
docs/developer/policy-engine.md Outdated Show resolved Hide resolved
docs/developer/policy-engine.md Outdated Show resolved Hide resolved
@juliapampus juliapampus force-pushed the refactor/remove_ids-policy_extension branch from f7edc1b to 6c1b18e Compare May 24, 2022 11:13
@juliapampus juliapampus requested a review from ndr-brt May 24, 2022 11:14
@juliapampus juliapampus force-pushed the refactor/remove_ids-policy_extension branch from 6c1b18e to 7956cf2 Compare May 24, 2022 11:14
@juliapampus juliapampus force-pushed the refactor/remove_ids-policy_extension branch from 7956cf2 to db090af Compare May 24, 2022 11:15
@@ -0,0 +1,248 @@
# Policy Engine
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably gets out of the scope here since it concerns "how to set up an extension" (that's missing from the doc currently), but since there are the details on how to set up the build file, probably we need to specify that a ServiceExtension file in the META-INF/services directory is needed

Connector automation moved this from In progress to Review in progress May 24, 2022
@juliapampus juliapampus merged commit ce6d67c into eclipse-edc:main May 24, 2022
Connector automation moved this from Review in progress to Done May 24, 2022
@juliapampus juliapampus deleted the refactor/remove_ids-policy_extension branch May 24, 2022 14:17
juliapampus added a commit to FraunhoferISST/edc-connector that referenced this pull request May 30, 2022
* refactor: remove :extensions:policy:ids-policy

* docs: add initial documentation on how to register policy functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Transform ids-policy to documentation
2 participants