New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ids policy extension #1348
refactor: remove ids policy extension #1348
Conversation
9e67fcf
to
f7edc1b
Compare
@@ -0,0 +1,248 @@ | |||
# Policy Engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably gets out of the scope here since it concerns "how to set up an extension" (that's missing from the doc currently), but since there are the details on how to set up the build file, probably we need to specify that a ServiceExtension
file in the META-INF/services
directory is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can remove this part and link to the "how to set up an extension" as soon as this is available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndr-brt I applied your feedback.
f7edc1b
to
6c1b18e
Compare
6c1b18e
to
7956cf2
Compare
7956cf2
to
db090af
Compare
@@ -0,0 +1,248 @@ | |||
# Policy Engine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably gets out of the scope here since it concerns "how to set up an extension" (that's missing from the doc currently), but since there are the details on how to set up the build file, probably we need to specify that a ServiceExtension
file in the META-INF/services
directory is needed
* refactor: remove :extensions:policy:ids-policy * docs: add initial documentation on how to register policy functions
What this PR changes/adds
Removes sample module
:extensions:policy:ids-policy
. Adds it as developer documentation.Why it does that
As discussed in #1114, this was something added to show how to register functions on the policy engine without any further uses.
Further notes
Maybe we have to take a further look on how this could be integrated in a more comprehensive policy documentation.
Linked Issue(s)
Closes #1156
Checklist
no-changelog
)