Chore: prepare publishing Maven artifacts to OSSRH and MavenCentral #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1354 +/- ##
============================================
- Coverage 67.68% 67.40% -0.28%
- Complexity 0 2885 +2885
============================================
Files 719 719
Lines 15859 15975 +116
Branches 1041 1052 +11
============================================
+ Hits 10734 10768 +34
- Misses 4650 4732 +82
Partials 475 475
Continue to review full report at Codecov.
|
juliapampus
requested changes
May 24, 2022
Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com>
Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com>
Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com>
|
will merge regardless of failing checks. There is already a fix for them: #1343 |
|
Can one of the admins verify this patch? |
JurajKubelka
added a commit
to JurajKubelka/DataSpaceConnector
that referenced
this pull request
May 26, 2022
* 'main' of github.com:JurajKubelka/DataSpaceConnector: refactor: remove basic launcher (eclipse-edc#1360) Chore: prepare publishing Maven artifacts to OSSRH and MavenCentral (eclipse-edc#1354) fix: load IdsTokenValidationServiceExtension properly (eclipse-edc#1352)
juliapampus
added a commit
to FraunhoferISST/edc-connector
that referenced
this pull request
May 30, 2022
…clipse-edc#1354) * add use gpg command * Update build.gradle.kts * Update build.gradle.kts * select repo url dependin on SNAPSHOT * changed OSSRH url * attempt to include java code * set pom to every publication * added documentation * added module list * Update README.md Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com> * Update README.md Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com> * Update README.md Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com> * updated modules file name * trigger CI * add clean-recreate on the modules list * use absolute path for modules.md * trigger CI Co-authored-by: Julia Pampus <72392527+juliapampus@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Why it does that
So that we can have lovely maven artifacts.
Further notes
As soon as this PR is merged we must update the JIPP (Eclipse Jenkins) build config to use
maininstead of this feature branchChecklist
no-changelog)