Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine close-inactive-issue workflow #1398

Merged

Conversation

juliapampus
Copy link
Contributor

@juliapampus juliapampus commented Jun 2, 2022

What this PR changes/adds

Extend operations-per-run from 30 to 200. Add -1 to either issue- or pr-specific param, as the top level parameter sets a default value we need to overwrite. Remove write permissions for issues or PRs as a step should only run on either issues or PRs.

Why it does that

see above

Further notes

--

Linked Issue(s)

Relates #1392

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1398 (1114b7d) into main (c6b7137) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage   67.70%   67.70%           
=======================================
  Files         718      718           
  Lines       15901    15901           
  Branches     1042     1042           
=======================================
  Hits        10766    10766           
  Misses       4659     4659           
  Partials      476      476           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6b7137...1114b7d. Read the comment docs.

@juliapampus juliapampus merged commit b4c6c3c into eclipse-edc:main Jun 2, 2022
@juliapampus juliapampus added this to In progress in Connector via automation Jun 8, 2022
@juliapampus juliapampus moved this from In progress to Done in Connector Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants