Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: dispatch contractdefinition events #1538

Merged
merged 2 commits into from
Jul 4, 2022
Merged

core: dispatch contractdefinition events #1538

merged 2 commits into from
Jul 4, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 24, 2022

What this PR changes/adds

Dispatch ContractDefinition events

Why it does that

To permit asynchronous notifications

Further notes

  • Moved observable interfaces & classes to the spi

Linked Issue(s)

Closes #1436

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@codecov-commenter
Copy link

Codecov Report

Merging #1538 (db65f0f) into main (385be86) will decrease coverage by 0.05%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##             main    #1538      +/-   ##
==========================================
- Coverage   67.16%   67.10%   -0.06%     
==========================================
  Files         736      741       +5     
  Lines       16139    16182      +43     
  Branches     1048     1048              
==========================================
+ Hits        10839    10859      +20     
- Misses       4823     4846      +23     
  Partials      477      477              
Impacted Files Coverage Δ
...or/api/datamanagement/asset/AssetApiExtension.java 100.00% <ø> (ø)
...datamanagement/asset/service/AssetServiceImpl.java 100.00% <ø> (ø)
...tamanagement/asset/service/EventAssetListener.java 100.00% <ø> (ø)
...anagement/policy/PolicyDefinitionApiExtension.java 100.00% <ø> (ø)
...nt/policy/service/PolicyDefinitionServiceImpl.java 94.11% <ø> (ø)
...definition/observe/ContractDefinitionListener.java 0.00% <0.00%> (ø)
...tion/observe/ContractDefinitionObservableImpl.java 0.00% <0.00%> (ø)
.../contractdefinition/ContractDefinitionCreated.java 0.00% <0.00%> (ø)
.../contractdefinition/ContractDefinitionDeleted.java 0.00% <0.00%> (ø)
...vent/policydefinition/PolicyDefinitionCreated.java 100.00% <ø> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385be86...db65f0f. Read the comment docs.

Connector automation moved this from In progress to Review in progress Jun 24, 2022
@ndr-brt ndr-brt merged commit 630f3d1 into eclipse-edc:main Jul 4, 2022
Connector automation moved this from Review in progress to Done Jul 4, 2022
@ndr-brt ndr-brt deleted the feature/1436-dispatch-contractdefinition-events branch July 4, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

Event Framework: dispatch ContractDefinition events
4 participants