token-auth: add vault support #1545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianrusch-zf
suggested changes
Jun 24, 2022
...src/main/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtension.java
Outdated
Show resolved
Hide resolved
|
Ah sorry, didn't saw, that the PR is still a draft 🙈 |
Feedback is always welcome :) |
DominikPinsel
force-pushed
the
feature/1537-support-vault-in-tokenbased-authentication
branch
4 times, most recently
from
ff8897f
to
6135138
Compare
DominikPinsel
requested review from
ndr-brt and
paullatzelsperger
as code owners
ndr-brt
approved these changes
Jun 28, 2022
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
DominikPinsel
force-pushed
the
feature/1537-support-vault-in-tokenbased-authentication
branch
from
6135138
to
0895729
Compare
paullatzelsperger
requested changes
Jun 28, 2022
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 67.53% 67.57% +0.04%
==========================================
Files 737 737
Lines 16201 16206 +5
Branches 1058 1060 +2
==========================================
+ Hits 10941 10952 +11
+ Misses 4782 4776 -6
Partials 478 478
Continue to review full report at Codecov.
|
DominikPinsel
force-pushed
the
feature/1537-support-vault-in-tokenbased-authentication
branch
3 times, most recently
from
f846b82
to
a0d6d42
Compare
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
...test/java/org/eclipse/dataspaceconnector/api/auth/TokenBasedAuthenticationExtensionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominik Pinsel <dominik.pinsel@daimler.com> Co-authored-by: Paul Latzelsperger <43503240+paullatzelsperger@users.noreply.github.com>
DominikPinsel
force-pushed
the
feature/1537-support-vault-in-tokenbased-authentication
branch
from
766fa9b
to
4fd308c
Compare
paullatzelsperger
approved these changes
Jun 28, 2022
ndr-brt
pushed a commit
that referenced
this pull request
Jun 28, 2022
Signed-off-by: Dominik Pinsel <dominik.pinsel@daimler.com> Co-authored-by: Paul Latzelsperger <43503240+paullatzelsperger@users.noreply.github.com> Co-authored-by: Paul Latzelsperger <43503240+paullatzelsperger@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Extension for token based authentication can now retrieve the authentication key from a vault.
see issue #1537
Why it does that
Further notes
Linked Issue(s)
Closes #1537
Checklist
no-changelog)Dominik Pinsel dominik.pinsel@daimler.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum