Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: remove run-from-junit sample module #1546

Merged
merged 1 commit into from
Jun 28, 2022
Merged

cleanup: remove run-from-junit sample module #1546

merged 1 commit into from
Jun 28, 2022

Conversation

ndr-brt
Copy link
Member

@ndr-brt ndr-brt commented Jun 27, 2022

What this PR changes/adds

Removes the run-from-junit sample

Why it does that

The sample lost its value in the last months, as now it's pretty straightforward to run a connector and write an end-to-end test on it.

Further notes

Linked Issue(s)

Part of #1456

Checklist

  • added appropriate tests?
  • performed checkstyle check locally?
  • added/updated copyright headers?
  • documented public classes/methods?
  • added/updated relevant documentation?
  • added relevant details to the changelog? (skip with label no-changelog)
  • formatted title correctly? (take a look at the CONTRIBUTING and styleguide for details)

@github-actions github-actions bot added this to In progress in Connector Jun 27, 2022
Connector automation moved this from In progress to Review in progress Jun 27, 2022
@ndr-brt ndr-brt merged commit f47ef60 into eclipse-edc:main Jun 28, 2022
Connector automation moved this from Review in progress to Done Jun 28, 2022
@ndr-brt ndr-brt deleted the cleanup/1456-remove-dead-code branch June 28, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Connector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants