chore(observability): Add context information to jetty metrics #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
reviewed
Jul 25, 2022
...ns/http/jetty/src/main/java/org/eclipse/dataspaceconnector/extension/jetty/JettyService.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/dataspaceconnector/extension/jetty/JettyMicrometerConfiguration.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/eclipse/dataspaceconnector/extension/jetty/JettyMicrometerConfiguration.java
Outdated
Show resolved
Hide resolved
The JettyMicrometerConfiguration was executed first, before the name and port were configured.
florianrusch-zf
force-pushed
the
1738-enrich-jetty-metrics-context-info
branch
from
ec1616d
to
b9cb0eb
Compare
florianrusch-zf
changed the title
florianrusch-zf
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1740 +/- ##
==========================================
+ Coverage 67.40% 67.41% +0.01%
==========================================
Files 781 781
Lines 16761 16757 -4
Branches 1057 1057
==========================================
- Hits 11297 11296 -1
+ Misses 5008 5005 -3
Partials 456 456
Continue to review full report at Codecov.
|
ndr-brt
approved these changes
Jul 27, 2022
|
removing myself, as @ndr-brt is already a reviewer. |
diegogomez-zf
pushed a commit
to diegogomez-zf/DataSpaceConnector
that referenced
this pull request
Aug 3, 2022
…se-edc#1740) * observability: Add context information to jetty metrics * observability: Update changelog * observability: Rework setting connector properties The JettyMicrometerConfiguration was executed first, before the name and port were configured. * observability: Fix typo in test description * observability: Remove changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
The PR adds the Tags
jetty_contextandjetty_portto the jetty connection metrics (e.g.jetty_connections_max)PR will result in this:
Why it does that
To support specific alerts for each context
Linked Issue(s)
Closes #1738
Checklist
added appropriate tests?(Not necessary in my opinion)documented public classes/methods?added/updated relevant documentation?no-changelog)